Avoid an out-of-bounds panic in deflate_stored #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn3
force-pushed
the
fix_deflate_stored_window_out_of_bounds
branch
from
895661d to
43ca3df
Compare
folkertdev
approved these changes
Dec 2, 2024
bjorn3
force-pushed
the
fix_deflate_stored_window_out_of_bounds
branch
from
43ca3df to
5e2f935
Compare
|
there is #254 btw |
|
Missed that PR. Approved it. |
bjorn3
force-pushed
the
fix_deflate_stored_window_out_of_bounds
branch
from
5e2f935 to
4118389
Compare
When shifting the window down, it is possible for the end of the window to be after the last initialized byte of the buffer. These uninitialized bytes don't affect the output of the compression, so we can safely skip copying them to avoid the panic. This matches the code a bit higher up which also does a window slide.
bjorn3
force-pushed
the
fix_deflate_stored_window_out_of_bounds
branch
from
4118389 to
2349467
Compare
folkertdev
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When shifting the window down, it is possible for the end of the window to be after the last initialized byte of the buffer. These uninitialized bytes don't affect the output of the compression, so we can safely skip copying them to avoid the panic. This matches the code a bit higher up which also does a window slide.
Fixes #229